git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 4b11c915f00caeef3292ed0429acc579b9da762a Mon Sep 17 00:00:00 2001
   2 From: Arend van Spriel <arend.vanspriel@broadcom.com>
   3 Date: Thu, 11 Jul 2019 11:05:12 +0200
   4 Subject: [PATCH] brcmfmac: remove unnecessary strlcpy() upon obtaining "ver"
   5  iovar
   6
   7 Recently a strcpy() was replaced by strlcpy(). However, the strcpy()
   8 was not needed in the first place. So removing that line of code.
   9
  10 Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
  11 Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
  12 Reviewed-by: Franky Lin <franky.lin@broadcom.com>
  13 Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
  14 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  15 ---
  16  drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 1 -
  17  1 file changed, 1 deletion(-)
  18
  19 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
  20 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
  21 @@ -258,7 +258,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
  22
  23         /* query for 'ver' to get version info from firmware */
  24         memset(buf, 0, sizeof(buf));
  25 -       strlcpy(buf, "ver", sizeof(buf));
  26         err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
  27         if (err < 0) {
  28                 bphy_err(drvr, "Retrieving version information failed, %d\n",