git.openwrt.org Git - openwrt/staging/neocturne.git/blob

   1 From 6186be80317d1dbda34d35c06c084a083938f2d3 Mon Sep 17 00:00:00 2001
   2 From: Chen Jiahao <chenjiahao16@huawei.com>
   3 Date: Wed, 2 Aug 2023 17:45:27 +0800
   4 Subject: [PATCH 32/42] thermal/drivers/mediatek: Clean up redundant
   5  dev_err_probe()
   6
   7 Referring to platform_get_irq()'s definition, the return value has
   8 already been checked if ret < 0, and printed via dev_err_probe().
   9 Calling dev_err_probe() one more time outside platform_get_irq()
  10 is obviously redundant.
  11
  12 Removing dev_err_probe() outside platform_get_irq() to clean up
  13 above problem.
  14
  15 Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
  16 Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  17 Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
  18 Link: https://lore.kernel.org/r/20230802094527.988842-1-chenjiahao16@huawei.com
  19 ---
  20  drivers/thermal/mediatek/lvts_thermal.c | 2 +-
  21  1 file changed, 1 insertion(+), 1 deletion(-)
  22
  23 --- a/drivers/thermal/mediatek/lvts_thermal.c
  24 +++ b/drivers/thermal/mediatek/lvts_thermal.c
  25 @@ -1216,7 +1216,7 @@ static int lvts_probe(struct platform_de
  26
  27         irq = platform_get_irq(pdev, 0);
  28         if (irq < 0)
  29 -               return dev_err_probe(dev, irq, "No irq resource\n");
  30 +               return irq;
  31
  32         ret = lvts_domain_init(dev, lvts_td, lvts_data);
  33         if (ret)