git.openwrt.org Git - openwrt/staging/jow.git/blob

   1 From 3905be68859b15731ec41b3d22cd1a9069375f7f Mon Sep 17 00:00:00 2001
   2 From: Dave Stevenson <dave.stevenson@raspberrypi.com>
   3 Date: Wed, 28 Apr 2021 12:32:10 +0200
   4 Subject: [PATCH] drm/vc4: Add debugfs node that dumps the vc5 gamma
   5  PWL entries
   6
   7 This helps with debugging the conversion from a 256 point gamma LUT to
   8 16 point PWL entries as used by the BCM2711.
   9
  10 Co-developed-by: Juerg Haefliger <juergh@canonical.com>
  11 Signed-off-by: Juerg Haefliger <juergh@canonical.com>
  12 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
  13 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
  14 ---
  15  drivers/gpu/drm/vc4/vc4_hvs.c | 85 ++++++++++++++++++++++++++++++++++-
  16  1 file changed, 84 insertions(+), 1 deletion(-)
  17
  18 --- a/drivers/gpu/drm/vc4/vc4_hvs.c
  19 +++ b/drivers/gpu/drm/vc4/vc4_hvs.c
  20 @@ -141,6 +141,85 @@ static int vc4_hvs_debugfs_dlist(struct
  21         return 0;
  22  }
  23
  24 +static int vc5_hvs_debugfs_gamma(struct seq_file *m, void *data)
  25 +{
  26 +       struct drm_info_node *node = m->private;
  27 +       struct drm_device *dev = node->minor->dev;
  28 +       struct vc4_dev *vc4 = to_vc4_dev(dev);
  29 +       struct vc4_hvs *hvs = vc4->hvs;
  30 +       struct drm_printer p = drm_seq_file_printer(m);
  31 +       unsigned int i, chan;
  32 +       u32 dispstat, dispbkgndx;
  33 +
  34 +       for (chan = 0; chan < SCALER_CHANNELS_COUNT; chan++) {
  35 +               u32 x_c, grad;
  36 +               u32 offset = SCALER5_DSPGAMMA_START +
  37 +                       chan * SCALER5_DSPGAMMA_CHAN_OFFSET;
  38 +
  39 +               dispstat = VC4_GET_FIELD(HVS_READ(SCALER_DISPSTATX(chan)),
  40 +                                        SCALER_DISPSTATX_MODE);
  41 +               if (dispstat == SCALER_DISPSTATX_MODE_DISABLED ||
  42 +                   dispstat == SCALER_DISPSTATX_MODE_EOF) {
  43 +                       drm_printf(&p, "HVS channel %u: Channel disabled\n", chan);
  44 +                       continue;
  45 +               }
  46 +
  47 +               dispbkgndx = HVS_READ(SCALER_DISPBKGNDX(chan));
  48 +               if (!(dispbkgndx & SCALER_DISPBKGND_GAMMA)) {
  49 +                       drm_printf(&p, "HVS channel %u: Gamma disabled\n", chan);
  50 +                       continue;
  51 +               }
  52 +
  53 +               drm_printf(&p, "HVS channel %u:\n", chan);
  54 +               drm_printf(&p, "  red:\n");
  55 +               for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
  56 +                       x_c = HVS_READ(offset);
  57 +                       grad = HVS_READ(offset + 4);
  58 +                       drm_printf(&p, "  %08x %08x - x %u, c %u, grad %u\n",
  59 +                                  x_c, grad,
  60 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
  61 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
  62 +                                  grad);
  63 +               }
  64 +               drm_printf(&p, "  green:\n");
  65 +               for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
  66 +                       x_c = HVS_READ(offset);
  67 +                       grad = HVS_READ(offset + 4);
  68 +                       drm_printf(&p, "  %08x %08x - x %u, c %u, grad %u\n",
  69 +                                  x_c, grad,
  70 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
  71 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
  72 +                                  grad);
  73 +               }
  74 +               drm_printf(&p, "  blue:\n");
  75 +               for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
  76 +                       x_c = HVS_READ(offset);
  77 +                       grad = HVS_READ(offset + 4);
  78 +                       drm_printf(&p, "  %08x %08x - x %u, c %u, grad %u\n",
  79 +                                  x_c, grad,
  80 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
  81 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
  82 +                                  grad);
  83 +               }
  84 +
  85 +               /* Alpha only valid on channel 2 */
  86 +               if (chan != 2)
  87 +                       continue;
  88 +
  89 +               drm_printf(&p, "  alpha:\n");
  90 +               for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
  91 +                       x_c = HVS_READ(offset);
  92 +                       grad = HVS_READ(offset + 4);
  93 +                       drm_printf(&p, "  %08x %08x - x %u, c %u, grad %u\n",
  94 +                                  x_c, grad,
  95 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
  96 +                                  VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
  97 +                                  grad);
  98 +               }
  99 +       }
 100 +       return 0;
 101 +}
 102 +
 103  /* The filter kernel is composed of dwords each containing 3 9-bit
 104   * signed integers packed next to each other.
 105   */
 106 @@ -833,11 +912,15 @@ int vc4_hvs_debugfs_init(struct drm_mino
 107         if (!vc4->hvs)
 108                 return -ENODEV;
 109
 110 -       if (!vc4->is_vc5)
 111 +       if (!vc4->is_vc5) {
 112                 debugfs_create_bool("hvs_load_tracker", S_IRUGO | S_IWUSR,
 113                                     minor->debugfs_root,
 114                                     &vc4->load_tracker_enabled);
 115
 116 +               vc4_debugfs_add_file(minor, "hvs_gamma", vc5_hvs_debugfs_gamma,
 117 +                                    NULL);
 118 +       }
 119 +
 120         ret = vc4_debugfs_add_file(minor, "hvs_dlists",
 121                                    vc4_hvs_debugfs_dlist, NULL);
 122         if (ret)