git.openwrt.org Git - openwrt/staging/981213.git/blob

   1 From 4774ad841bef97cc51df90195338c5b2573dd4cb Mon Sep 17 00:00:00 2001
   2 From: Christian Marangi <ansuelsmth@gmail.com>
   3 Date: Sun, 23 Apr 2023 19:28:00 +0200
   4 Subject: [PATCH] net: phy: marvell: Fix inconsistent indenting in
   5  led_blink_set
   6
   7 Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
   8 test robot, probably done by the presence of an if condition dropped in
   9 later revision of the same code.
  10
  11 Reported-by: kernel test robot <lkp@intel.com>
  12 Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
  13 Fixes: ea9e86485dec ("net: phy: marvell: Implement led_blink_set()")
  14 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
  15 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  16 Link: https://lore.kernel.org/r/20230423172800.3470-1-ansuelsmth@gmail.com
  17 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  18 ---
  19  drivers/net/phy/marvell.c | 8 ++++----
  20  1 file changed, 4 insertions(+), 4 deletions(-)
  21
  22 --- a/drivers/net/phy/marvell.c
  23 +++ b/drivers/net/phy/marvell.c
  24 @@ -2880,10 +2880,10 @@ static int m88e1318_led_blink_set(struct
  25         case 1:
  26         case 2:
  27                 reg &= ~(0xf << (4 * index));
  28 -                       reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
  29 -                       /* Reset default is 84ms */
  30 -                       *delay_on = 84 / 2;
  31 -                       *delay_off = 84 / 2;
  32 +               reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
  33 +               /* Reset default is 84ms */
  34 +               *delay_on = 84 / 2;
  35 +               *delay_off = 84 / 2;
  36                 break;
  37         default:
  38                 return -EINVAL;