git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From c33330ac06fe863289643e7a13ecdb6a2502dad7 Mon Sep 17 00:00:00 2001
   2 From: Arend van Spriel <arend.vanspriel@broadcom.com>
   3 Date: Thu, 11 Jul 2019 11:05:09 +0200
   4 Subject: [PATCH] brcmfmac: clear events in brcmf_fweh_detach() will always
   5  fail
   6
   7 Clearing firmware events in brcmf_fweh_detach() is always failing
   8 because it is called only upon driver remove and communication
   9 with firmware is no longer possible.
  10
  11 Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
  12 Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
  13 Reviewed-by: Franky Lin <franky.lin@broadcom.com>
  14 Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
  15 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  16 ---
  17  drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 9 ---------
  18  1 file changed, 9 deletions(-)
  19
  20 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
  21 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
  22 @@ -303,16 +303,7 @@ void brcmf_fweh_attach(struct brcmf_pub
  23  void brcmf_fweh_detach(struct brcmf_pub *drvr)
  24  {
  25         struct brcmf_fweh_info *fweh = &drvr->fweh;
  26 -       struct brcmf_if *ifp = brcmf_get_ifp(drvr, 0);
  27 -       s8 eventmask[BRCMF_EVENTING_MASK_LEN];
  28
  29 -       if (ifp) {
  30 -               /* clear all events */
  31 -               memset(eventmask, 0, BRCMF_EVENTING_MASK_LEN);
  32 -               (void)brcmf_fil_iovar_data_set(ifp, "event_msgs",
  33 -                                              eventmask,
  34 -                                              BRCMF_EVENTING_MASK_LEN);
  35 -       }
  36         /* cancel the worker */
  37         cancel_work_sync(&fweh->event_work);
  38         WARN_ON(!list_empty(&fweh->event_q));