scsi: sd: Make protection lookup tables static and relocate functions
authorJohn Garry <john.garry@huawei.com>
Tue, 8 Jan 2019 15:14:52 +0000 (23:14 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 9 Jan 2019 03:29:32 +0000 (22:29 -0500)
commit082c2cd2030e5e9322c835f577fdc9acff41ee5b
tree98eb52338bc7ddbce55b3a55b17ef122e47d3b98
parent1afb4b8524797f95b15480a6654780571cde4e56
scsi: sd: Make protection lookup tables static and relocate functions

Currently the protection lookup tables in sd_prot_flag_mask() and
sd_prot_op() are declared as non-static. As such, they will be rebuilt for
each respective function call.

Optimise by making them static.

This saves ~100B object code for sd.c:

Before:
   text    data     bss     dec     hex filename
  25403    1024      16   26443    674b drivers/scsi/sd.o

After:
  text    data     bss     dec     hex filename
  25299    1024      16   26339    66e3 drivers/scsi/sd.o

In addition, since those same functions are declared in sd.h, but each are
only referenced in sd.c, relocate them to that same c file.

The inline specifier is dropped also, since gcc should be able to make the
decision to inline.

Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c
drivers/scsi/sd.h