drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 1 Nov 2017 20:15:58 +0000 (22:15 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 20 Nov 2017 18:33:21 +0000 (20:33 +0200)
commit10b47ee02d1ae66160058241cf5b962f64e81b47
treed8158b85c8518b7be38449f12be36300710fb834
parent58a275aa956498ccf964678767560b0c91f31a23
drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

drm_plane_helper_check_state() is supposed to do things the atomic way,
so it should not be inspecting crtc->enabled. Rather we should be
looking at crtc_state->enable.

We have a slight complication due to drm_plane_helper_check_update()
reusing drm_plane_helper_check_state() for non-atomic drivers. Thus
we'll have to pass the crtc_state in manally and construct a fake
crtc_state in drm_plane_helper_check_update().

v2: Fix the WARNs about plane_state->crtc matching crtc_state->crtc

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171101201558.6059-1-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
15 files changed:
drivers/gpu/drm/arm/hdlcd_crtc.c
drivers/gpu/drm/arm/malidp_planes.c
drivers/gpu/drm/drm_plane_helper.c
drivers/gpu/drm/drm_simple_kms_helper.c
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/imx/ipuv3-plane.c
drivers/gpu/drm/mediatek/mtk_drm_plane.c
drivers/gpu/drm/meson/meson_plane.c
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
drivers/gpu/drm/nouveau/nv50_display.c
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
drivers/gpu/drm/tegra/dc.c
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
drivers/gpu/drm/zte/zx_plane.c
include/drm/drm_plane_helper.h