locking/qspinlock: Ensure node->count is updated before initialising node
authorWill Deacon <will.deacon@arm.com>
Tue, 13 Feb 2018 13:22:57 +0000 (13:22 +0000)
committerIngo Molnar <mingo@kernel.org>
Tue, 13 Feb 2018 13:50:14 +0000 (14:50 +0100)
commit11dc13224c975efcec96647a4768a6f1bb7a19a8
tree137d28b601e742a4d05b4720c9a280f867f31609
parent95bcade33a8af38755c9b0636e36a36ad3789fe6
locking/qspinlock: Ensure node->count is updated before initialising node

When queuing on the qspinlock, the count field for the current CPU's head
node is incremented. This needn't be atomic because locking in e.g. IRQ
context is balanced and so an IRQ will return with node->count as it
found it.

However, the compiler could in theory reorder the initialisation of
node[idx] before the increment of the head node->count, causing an
IRQ to overwrite the initialised node and potentially corrupt the lock
state.

Avoid the potential for this harmful compiler reordering by placing a
barrier() between the increment of the head node->count and the subsequent
node initialisation.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1518528177-19169-3-git-send-email-will.deacon@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/qspinlock.c