libata: Un-break ATA blacklist
authorGeorge Spelvin <linux@horizon.com>
Tue, 7 Oct 2014 11:26:38 +0000 (07:26 -0400)
committerTejun Heo <tj@kernel.org>
Tue, 7 Oct 2014 21:10:00 +0000 (17:10 -0400)
commit1c40279960bcd7d52dbdf1d466b20d24b99176c8
tree39035a38f06cf7c84bb246c1b3029986fbd83209
parent33fb0d01ce60fe4c0c12c4f0c134c5cdb818ac5a
libata: Un-break ATA blacklist

lib/glob.c provides a new glob_match() function, with arguments in
(pattern, string) order.  It replaced a private function with arguments
in (string, pattern) order, but I didn't swap the call site...

The result was the entire ATA blacklist was effectively disabled.

The lesson for today is "I f***ed up *how* badly *how* many months ago?",
er, I mean "Nobody Tests RC Kernels On Legacy Hardware".

This was not a subtle break, but it made it through an entire RC
cycle unreported, presumably because all the people doing testing
have full-featured hardware.

(FWIW, the reason for the argument swap was because fnmatch() does it that
way, and for a while implementing a full fnmatch() was being considered.)

Fixes: 428ac5fc056e0 (libata: Use glob_match from lib/glob.c)
Reported-by: Steven Honeyman <stevenhoneyman@gmail.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=71371#c21
Signed-off-by: George Spelvin <linux@horizon.com>
Cc: <stable@vger.kernel.org> # 3.17
Tested-by: Steven Honeyman <stevenhoneyman@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-core.c