bridge: use the bridge IP addr as source addr for querier
authorCong Wang <amwang@redhat.com>
Tue, 21 May 2013 21:52:54 +0000 (21:52 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 May 2013 21:54:37 +0000 (14:54 -0700)
commit1c8ad5bfa2be5025b0c81e3c2decd0574d453ab1
treef69ac9d37009526ae924c23940207b6531534f9f
parent4f45c40f2c018e5c278988521a74fd5ee06fb819
bridge: use the bridge IP addr as source addr for querier

Quote from Adam:
"If it is believed that the use of 0.0.0.0
as the IP address is what is causing strange behaviour on other devices
then is there a good reason that a bridge rather than a router shouldn't
be the active querier? If not then using the bridge IP address and
having the querier enabled by default may be a reasonable solution
(provided that our querier obeys the election rules and shuts up if it
sees a query from a lower IP address that isn't 0.0.0.0). Just because a
device is the elected querier for IGMP doesn't appear to mean it is
required to perform any other routing functions."

And introduce a new troggle for it, as suggested by Herbert.

Suggested-by: Adam Baker <linux@baker-net.org.uk>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Adam Baker <linux@baker-net.org.uk>
Signed-off-by: Cong Wang <amwang@redhat.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_multicast.c
net/bridge/br_private.h
net/bridge/br_sysfs_br.c