Integrity: IMA file free imbalance
authorMimi Zohar <zohar@linux.vnet.ibm.com>
Wed, 4 Feb 2009 14:07:02 +0000 (09:07 -0500)
committerJames Morris <jmorris@namei.org>
Thu, 5 Feb 2009 22:05:33 +0000 (09:05 +1100)
commit1df9f0a73178718969ae47d813b8e7aab2cf073c
tree6bd3d8838858f0e93acd8f7969b7d0e5ce2bfb08
parentf4bd857bc8ed997c25ec06b56ef8064aafa6d4f3
Integrity: IMA file free imbalance

The number of calls to ima_path_check()/ima_file_free()
should be balanced.  An extra call to fput(), indicates
the file could have been accessed without first being
measured.

Although f_count is incremented/decremented in places other
than fget/fput, like fget_light/fput_light and get_file, the
current task must already hold a file refcnt.  The call to
__fput() is delayed until the refcnt becomes 0, resulting
in ima_file_free() flagging any changes.

- add hook to increment opencount for IPC shared memory(SYSV),
  shmat files, and /dev/zero
- moved NULL iint test in opencount_get()

Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
include/linux/ima.h
ipc/shm.c
mm/shmem.c
security/integrity/ima/ima.h
security/integrity/ima/ima_iint.c
security/integrity/ima/ima_main.c