drm/vc4: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Sat, 8 Sep 2018 13:46:46 +0000 (15:46 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Tue, 25 Sep 2018 09:35:06 +0000 (11:35 +0200)
commit233386d8f22b62ea9c725226067b89c3ecb701d3
treeddcaea8286e99be1b007289f5495de4da14b9cab
parent1e70d7a568fc6e1e9df1b7e86216b44ce7d1eb1b
drm/vc4: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

drm_fbdev_generic_setup() handles mode_config.num_connector being zero.
In that case it retries fbdev setup on the next .output_poll_changed.

Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180908134648.2582-19-noralf@tronnes.org
drivers/gpu/drm/vc4/vc4_drv.c
drivers/gpu/drm/vc4/vc4_kms.c