pinctrl: actions: fix unsigned less than zero comparison
authorColin Ian King <colin.king@canonical.com>
Mon, 2 Jul 2018 12:47:08 +0000 (13:47 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 2 Jul 2018 14:05:01 +0000 (16:05 +0200)
commit23ee0f192033ac6742fc179699d91336a000aef5
tree9a604c2f387cdf6252eb5fe8276155f295f1d1bd
parent875a92b3f58a117842c0f9e8d65355c6be218fa2
pinctrl: actions: fix unsigned less than zero comparison

The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero.  Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.

Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")

Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/actions/pinctrl-owl.c