perf probe: Ensure offset provided is not greater than function length
authorPrashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Fri, 24 Feb 2012 07:41:39 +0000 (13:11 +0530)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 29 Feb 2012 21:29:45 +0000 (18:29 -0300)
commit26b7952494772f0e695271fbd6cf83a852f60f25
tree168c92dc039cbd205b848c33da7020ea5b02a074
parent30e68bcc67e41ab6dab4e4e1efc7ea8ca893c0af
perf probe: Ensure offset provided is not greater than function length

The perf probe command allows kprobe to be inserted at any offset from a
function start, which results in adding kprobes to unintended location.

Example: perf probe do_fork+10000 is allowed even though size of do_fork
is ~904.

This patch will ensure probe addition fails when the offset specified is
greater than size of the function.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/4F473F33.4060409@linux.vnet.ibm.com
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-finder.c