projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5e66e35) | patch
skge: potential memory corruption in skge_get_regs()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Feb 2019 08:28:16 +0000 (11:28 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Feb 2019 18:00:22 +0000 (10:00 -0800)
commit294c149a209c6196c2de85f512b52ef50f519949
treebac41b5c5e67a0fd4cdde48757d9a71d3259f643tree | snapshot
parent5e66e35aab335b83d9ffb220d8a3a13986a7a60ecommit | diff
skge: potential memory corruption in skge_get_regs()

The "p" buffer is 0x4000 bytes long.  B3_RI_WTO_R1 is 0x190.  The value
of "regs->len" is in the 1-0x4000 range.  The bug here is that
"regs->len - B3_RI_WTO_R1" can be a negative value which would lead to
memory corruption and an abrupt crash.

Fixes: c3f8be961808 ("[PATCH] skge: expand ethtool debug register dump")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/skge.c diff | blob | history
John Crispins staging tree