Merge branch 'proc-cmdline' (/proc/<pid>/cmdline fixes)
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 16 Jul 2019 17:37:27 +0000 (10:37 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 16 Jul 2019 17:37:27 +0000 (10:37 -0700)
commit2954152298c37804dab49d630aa959625b50cf64
treea53f1164306acb521bd57cfc5083962901828000
parent50950626414a982c8ed539128c7f69a3d328a970
parentd26d0cd97c88eb1a5704b42e41ab443406807810
Merge branch 'proc-cmdline' (/proc/<pid>/cmdline fixes)

This fixes two problems reported with the cmdline simplification and
cleanup last year:

 - the setproctitle() special cases didn't quite match the original
   semantics, and it can be noticeable:

      https://lore.kernel.org/lkml/alpine.LNX.2.21.1904052326230.3249@kich.toxcorp.com/

 - it could leak an uninitialized byte from the temporary buffer under
   the right (wrong) circustances:

      https://lore.kernel.org/lkml/20190712160913.17727-1-izbyshev@ispras.ru/

It rewrites the logic entirely, splitting it into two separate commits
(and two separate functions) for the two different cases ("unedited
cmdline" vs "setproctitle() has been used to change the command line").

* proc-cmdline:
  /proc/<pid>/cmdline: add back the setproctitle() special case
  /proc/<pid>/cmdline: remove all the special cases
fs/proc/base.c