cifs: allow calling SMB2_xxx_free(NULL)
authorRonnie Sahlberg <lsahlber@redhat.com>
Wed, 24 Oct 2018 01:50:33 +0000 (11:50 +1000)
committerSteve French <stfrench@microsoft.com>
Wed, 24 Oct 2018 12:21:41 +0000 (07:21 -0500)
commit32a1fb36f6e50183871c2c1fcf5493c633e84732
treeab417190efe7b6e03b36cfaf91ec4b47ff807f36
parent35a908072311b8efce8467161ea870cd410a1d68
cifs: allow calling SMB2_xxx_free(NULL)

Change these free functions to allow passing NULL as the argument and
treat it as a no-op just like free(NULL) would.
Or, if rqst->rq_iov is NULL.

The second scenario could happen for smb2_queryfs() if the call
to SMB2_query_info_init() fails and we go to qfs_exit to clean up
and free all resources.
In that case we have not yet assigned rqst[2].rq_iov and thus
the rq_iov dereference in SMB2_close_free() will cause a NULL pointer
dereference.

Fixes: 1eb9fb52040f ("cifs: create SMB2_open_init()/SMB2_open_free() helpers")
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
CC: Stable <stable@vger.kernel.org>
fs/cifs/smb2pdu.c