cfg80211: Change an 'else if' into an 'else' in cfg80211_calculate_bitrate_he
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 7 Mar 2019 23:57:35 +0000 (16:57 -0700)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 29 Mar 2019 10:22:23 +0000 (11:22 +0100)
commit344c9719c508bb3ef4e9c134066c83ff00ab6206
treea065fb600388021357b9feab370c3c14c0176225
parenteb9b64e3a9f8483e6e54f4e03b2ae14ae5db2690
cfg80211: Change an 'else if' into an 'else' in cfg80211_calculate_bitrate_he

When building with -Wsometimes-uninitialized, Clang warns:

net/wireless/util.c:1223:11: warning: variable 'result' is used
uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

Clang can't evaluate at this point that WARN(1, ...) always returns true
because __ret_warn_on is defined as !!(condition), which isn't
immediately evaluated as 1. Change this branch to else so that it's
clear to Clang that we intend to bail out here.

Link: https://github.com/ClangBuiltLinux/linux/issues/382
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/util.c