megaraid_sas: add missing curly braces in ioctl handler
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:29:45 +0000 (15:29 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 18 Mar 2016 19:22:55 +0000 (15:22 -0400)
commit3deb9438d34a09f6796639b652a01d110aca9f75
tree1b22dbfd712b679aa6f23c0c51af55f37af09128
parentaeb6641f8ebdd61939f462a8255b316f9bfab707
megaraid_sas: add missing curly braces in ioctl handler

gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
function:

drivers/scsi/megaraid/megaraid_sas_base.c: In function 'megasas_mgmt_fw_ioctl':
drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
    kbuff_arr[i] = NULL;
    ^~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_base.c:6653:3: note: ...this 'if' clause, but it is not
   if (kbuff_arr[i])
   ^~

The code is actually correct, as there is no downside in clearing a NULL
pointer again.

This clarifies the code and avoids the warning by adding extra curly
braces.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 90dc9d98f01b ("megaraid_sas : MFI MPT linked list corruption fix")
Reviewed-by: Hannes Reinecke <hare@suse.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c