brcmfmac: fix false-positive -Wmaybe-unintialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 10 Dec 2018 20:55:37 +0000 (21:55 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 13 Dec 2018 14:59:00 +0000 (16:59 +0200)
commit412dd15c8177d93abe0c8787b83b31c5eb061405
treeec0773802ba8aa5e6d58a526ecef8ee99f515db8
parent29f6589140a10ece8c1d73f58043ea5b3473ab3e
brcmfmac: fix false-positive -Wmaybe-unintialized warning

When CONFIG_NO_AUTO_INLINE is set, we get a false-postive warning
for the brcmf_fw_request_nvram_done() function, after gcc figures
out that brcmf_fw_nvram_from_efi() might not set the 'data_len'
variable, but fails to notice that it always returns NULL:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:560:11: error: 'data_len' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Mark it 'inline' to force gcc to understand this.

Fixes: ce2e6db554fa ("brcmfmac: Add support for getting nvram contents from EFI variables")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c