fscrypt: fix renaming and linking special files
authorEric Biggers <ebiggers@google.com>
Mon, 19 Dec 2016 22:20:13 +0000 (14:20 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 31 Dec 2016 05:47:05 +0000 (00:47 -0500)
commit42d97eb0ade31e1bc537d086842f5d6e766d9d51
tree04f4a277ddf959f3cabb6a97c7743806d9bd953e
parentfe4f6c801c03bc13113d0dc32f02d4ea8ed89ffd
fscrypt: fix renaming and linking special files

Attempting to link a device node, named pipe, or socket file into an
encrypted directory through rename(2) or link(2) always failed with
EPERM.  This happened because fscrypt_has_permitted_context() saw that
the file was unencrypted and forbid creating the link.  This behavior
was unexpected because such files are never encrypted; only regular
files, directories, and symlinks can be encrypted.

To fix this, make fscrypt_has_permitted_context() always return true on
special files.

This will be covered by a test in my encryption xfstests patchset.

Fixes: 9bd8212f981e ("ext4 crypto: add encryption policy and password salt support")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Cc: stable@vger.kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/crypto/policy.c