netfilter: nf_tables: don't use position attribute on rule replacement
authorFlorian Westphal <fw@strlen.de>
Sun, 4 Nov 2018 11:07:14 +0000 (12:07 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 12 Nov 2018 15:13:35 +0000 (16:13 +0100)
commit447750f281abef547be44fdcfe3bc4447b3115a8
treec1594fd1620fdf8115d90af32e52d2a11a86d1cf
parent25d8bcedbf4329895dbaf9dd67baa6f18dad918c
netfilter: nf_tables: don't use position attribute on rule replacement

Its possible to set both HANDLE and POSITION when replacing a rule.
In this case, the rule at POSITION gets replaced using the
userspace-provided handle.  Rule handles are supposed to be generated
by the kernel only.

Duplicate handles should be harmless, however better disable this "feature"
by only checking for the POSITION attribute on insert operations.

Fixes: 5e94846686d0 ("netfilter: nf_tables: add insert operation")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c