drm/i915: Handle recursive shrinker for vma->last_active allocation
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 19 Jul 2018 07:22:06 +0000 (08:22 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 19 Jul 2018 11:27:46 +0000 (12:27 +0100)
commit46b1063f91e5680eff2a6b9fe432f6aae3bef54e
treedaf50db29b5d08e593ef226c396d1c4155431ab2
parent209b7955e59e361fe8ba1911fac68f46355ac0cf
drm/i915: Handle recursive shrinker for vma->last_active allocation

If we call into the shrinker for direct relcaim inside kmalloc, it will
retire the requests. If we retire the vma->last_active while processing a
new i915_vma_move_to_active() we can upset the delicate bookkeeping
required for the cache. After the possible invocation of the shrinker, we
need to double check the vma->last_active is still valid.

Fixes: 8b293eb53a7d ("drm/i915: Track the last-active inside the i915_vma")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105600#c39
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180719072206.16015-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_vma.c