mac80211: fix potential null pointer dereference
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 18 Jun 2018 12:41:34 +0000 (07:41 -0500)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 29 Jun 2018 07:50:43 +0000 (09:50 +0200)
commit47aa7861b9bf8e8a540f3b11971e4a3f631e8ff4
treecfb5602c40026b9eeada4953d13e49dc49adbc21
parentfe0984d38938249f3f11fc558a8845fc6f8a0105
mac80211: fix potential null pointer dereference

he_op is being dereferenced before it is null checked, hence there
is a potential null pointer dereference.

Fix this by moving the pointer dereference after he_op has been
properly null checked.

Notice that, currently, he_op is already being null checked before
calling this function at 4593:

4593 if (!he_oper ||
4594     !ieee80211_verify_sta_he_mcs_support(sband, he_oper))
4595 ifmgd->flags |= IEEE80211_STA_DISABLE_HE;

but in case ieee80211_verify_sta_he_mcs_support is ever called
without verifying he_oper is not null, we will end up having a
null pointer dereference. So, we better don't take any chances.

Addresses-Coverity-ID: 1470068 ("Dereference before null check")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c