net/mlx4_en: fix a memory leak bug
authorWenwen Wang <wenwen@cs.uga.edu>
Mon, 12 Aug 2019 19:11:35 +0000 (14:11 -0500)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 14 Aug 2019 02:42:43 +0000 (19:42 -0700)
commit48ec7014c56e5eb2fbf6f479896143622d834f3b
treeb70fc7b157fcdd452d3f01a58193c6d7d541c818
parent66cf4710b23ab2adda11155684a2c8826f4fe732
net/mlx4_en: fix a memory leak bug

In mlx4_en_config_rss_steer(), 'rss_map->indir_qp' is allocated through
kzalloc(). After that, mlx4_qp_alloc() is invoked to configure RSS
indirection. However, if mlx4_qp_alloc() fails, the allocated
'rss_map->indir_qp' is not deallocated, leading to a memory leak bug.

To fix the above issue, add the 'qp_alloc_err' label to free
'rss_map->indir_qp'.

Fixes: 4931c6ef04b4 ("net/mlx4_en: Optimized single ring steering")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
drivers/net/ethernet/mellanox/mlx4/en_rx.c