Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL...
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 5 Jun 2019 04:27:14 +0000 (12:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 00:54:46 +0000 (17:54 -0700)
commit4970b42d5c362bf873982db7d93245c5281e58f4
treede30ac9a286dc66474dc7dd3ecf62d34d1a47760
parent930b9a0543385d4eb8ef887e88cf84d95a844577
Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"

This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849.

Nathan reported the new behaviour breaks Android, as Android just add
new rules and delete old ones.

If we return 0 without adding dup rules, Android will remove the new
added rules and causing system to soft-reboot.

Fixes: e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: Yaro Slav <yaro330@gmail.com>
Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/fib_rules.c