xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()
authorJuergen Gross <jgross@suse.com>
Fri, 14 Jun 2019 05:46:02 +0000 (07:46 +0200)
committerJuergen Gross <jgross@suse.com>
Thu, 1 Aug 2019 04:39:27 +0000 (06:39 +0200)
commit50f6393f9654c561df4cdcf8e6cfba7260143601
tree1df0049d8d584dc01648b412d1fc80106b5c1784
parenta78d14a31666c636a9e00a589032119fb59e3b94
xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()

The condition in xen_swiotlb_free_coherent() for deciding whether to
call xen_destroy_contiguous_region() is wrong: in case the region to
be freed is not contiguous calling xen_destroy_contiguous_region() is
the wrong thing to do: it would result in inconsistent mappings of
multiple PFNs to the same MFN. This will lead to various strange
crashes or data corruption.

Instead of calling xen_destroy_contiguous_region() in that case a
warning should be issued as that situation should never occur.

Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/swiotlb-xen.c