drm/i915: Flush ggtt writes through the old fenced vma before changing fences
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 30 Jan 2018 16:44:57 +0000 (16:44 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 31 Jan 2018 10:49:16 +0000 (10:49 +0000)
commit5b364bec5cbfd6c23505952a40150b053ec551d1
tree2b4d76ce4a9d39b7b1940bc0ff5a8c344c82b78b
parentb1852d362f31ac0c233e7c7b040f7c58bd381267
drm/i915: Flush ggtt writes through the old fenced vma before changing fences

This is a precautionary measure as I have no evidence to suggest we've
hit a bug here (I was hoping this might explain gdg's odd behaviour, but
alas), but given that we have a function to flush the ggtt writes it
seems prudent to use it prior to changing the fence register. Due to the
intrinsic nature of the GTT often operating as an independent mmio path,
we should not just rely on the write to the fence acting as a full flush
for GTT writes.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180130164457.14037-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem_fence_reg.c