net: don't keep lonely packets forever in the gro hash
authorPaolo Abeni <pabeni@redhat.com>
Wed, 21 Nov 2018 17:21:35 +0000 (18:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Nov 2018 19:18:53 +0000 (11:18 -0800)
commit605108acfe6233b72e2f803aa1cb59a2af3001ca
tree7176a1fdfdd38c73fcf4d40ed76db3dcfc337b9e
parent896585d48e8e9ba44cd1754fbce8537feffcc1a5
net: don't keep lonely packets forever in the gro hash

Eric noted that with UDP GRO and NAPI timeout, we could keep a single
UDP packet inside the GRO hash forever, if the related NAPI instance
calls napi_gro_complete() at an higher frequency than the NAPI timeout.
Willem noted that even TCP packets could be trapped there, till the
next retransmission.
This patch tries to address the issue, flushing the old packets -
those with a NAPI_GRO_CB age before the current jiffy - before scheduling
the NAPI timeout. The rationale is that such a timeout should be
well below a jiffy and we are not flushing packets eligible for sane GRO.

v1  -> v2:
 - clarified the commit message and comment

RFC -> v1:
 - added 'Fixes tags', cleaned-up the wording.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Fixes: 3b47d30396ba ("net: gro: add a per device gro flush timer")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c