KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
authorLiran Alon <liran.alon@oracle.com>
Mon, 15 Jul 2019 15:47:44 +0000 (18:47 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 15 Jul 2019 18:40:58 +0000 (20:40 +0200)
commit6694e48012826351036fd10fc506ca880023e25f
treebc5d3faa50f4a6df7f454ffa9c2b50c9191e733f
parent0d88800d547211ce07be3551c812d404cf2be3a8
KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS

As reported by Maxime at
https://bugzilla.kernel.org/show_bug.cgi?id=204175:

In vmx/nested.c::get_vmx_mem_address(), when the guest runs in long mode,
the base address of the memory operand is computed with a simple:
    *ret = s.base + off;

This is incorrect, the base applies only to FS and GS, not to the others.
Because of that, if the guest uses a VMX instruction based on DS and has
a DS.base that is non-zero, KVM wrongfully adds the base to the
resulting address.

Reported-by: Maxime Villard <max@m00nbsd.net>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx/nested.c