target: Avoid dropping AllRegistrants reservation during unregister
authorNicholas Bellinger <nab@linux-iscsi.org>
Mon, 15 Dec 2014 19:50:26 +0000 (11:50 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 16 Dec 2014 04:38:34 +0000 (20:38 -0800)
commit6c3c9baa0debeb4bcc52a78c4463a0a97518de10
tree73ff0c1adb684784f2e2d6ca4ca2977ccc2e5a93
parentd16ca7c5198fd668db10d2c7b048ed3359c12c54
target: Avoid dropping AllRegistrants reservation during unregister

This patch fixes an issue with AllRegistrants reservations where
an unregister operation by the I_T nexus reservation holder would
incorrectly drop the reservation, instead of waiting until the
last active I_T nexus is unregistered as per SPC-4.

This includes updating __core_scsi3_complete_pro_release() to reset
dev->dev_pr_res_holder with another pr_reg for this special case,
as well as a new 'unreg' parameter to determine when the release
is occuring from an implicit unregister, vs. explicit RELEASE.

It also adds special handling in core_scsi3_free_pr_reg_from_nacl()
to release the left-over pr_res_holder, now that pr_reg is deleted
from pr_reg_list within __core_scsi3_complete_pro_release().

Reported-by: Ilias Tsitsimpis <i.tsitsimpis@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_pr.c