drm/i915: Deprecate I915_SET_COLORKEY_NONE
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 2 Feb 2018 20:42:31 +0000 (22:42 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 5 Feb 2018 18:54:01 +0000 (20:54 +0200)
commit6ec5bd348934887494541bcc9b53d621b1f2962c
treeb95b8ce404dcb6e931617f36cb7000c9c639e488
parent01b8fdc5222007bdfc905941173f82576898a7f7
drm/i915: Deprecate I915_SET_COLORKEY_NONE

Deprecate the silly I915_SET_COLORKEY_NONE flag. The obvious
way to disable colorkey is to just set flags to 0, which is
exactly what the intel ddx has been doing all along.

Currently when userspace sets the flags to 0, we end up in a
funny state where colorkey is disabled, but various colorkey
vs. scaling checks still consider colorkey to be enabled, and
thus we don't allow plane scaling to kick in.

In case there is some other userspace out there that actually
uses this flag (unlikely as this is an i915 specific uapi)
we'll keep on accepting it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180202204231.27905-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_atomic_plane.c
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_sprite.c
include/uapi/drm/i915_drm.h