ncr5380: Dont re-enter NCR5380_select()
authorFinn Thain <fthain@telegraphics.com.au>
Mon, 22 Feb 2016 23:07:06 +0000 (10:07 +1100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Mar 2016 14:38:14 +0000 (09:38 -0500)
commit71a00593ec0c2e2c1720e4041cf2926ff1d07826
treeb2ce847507a10dfc62cbdac8fb76809c6e62ac82
parent1678847ec93040ae8280d19c42ae0ba8a4233e6d
ncr5380: Dont re-enter NCR5380_select()

Calling NCR5380_select() from the abort handler causes various problems.
Firstly, it means potentially re-entering NCR5380_select(). Secondly, it
means that the lock is released, which permits the EH handlers to be
re-entered. The combination results in crashes. Don't do it.

Fixes: 8b00c3d5d40d ("ncr5380: Implement new eh_abort_handler")
Reported-and-tested-by: Michael Schmitz <schmitzmic@gmail.com>
Cc: <stable@vger.kernel.org> # 4.5
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/NCR5380.c
drivers/scsi/atari_NCR5380.c