projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 13fa745) | patch
netfilter: arp_tables: remove redundant check on ret being non-zero
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Feb 2017 11:31:15 +0000 (11:31 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 6 Mar 2017 17:04:37 +0000 (18:04 +0100)
commit74664cf286dc0d2bf6960293cb219e5f741ac92b
treef2a3d857d155dc9d25314a0dc374c2588f8b17d2tree | snapshot
parent13fa745da251606fcdbf58acd6b4a551bea6ae99commit | diff
netfilter: arp_tables: remove redundant check on ret being non-zero

ret is initialized to zero and if it is set to non-zero in the
xt_entry_foreach loop then we exit via the out_free label. Hence
the check for ret being non-zero is redundant and can be removed.

Detected by CoverityScan, CID#1357132 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/arp_tables.c diff | blob | history
John Crispins staging tree