tools lib traceevent: Fix buffer overflow in arg_eval
authorTony Jones <tonyj@suse.de>
Thu, 28 Feb 2019 01:55:32 +0000 (17:55 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 28 Feb 2019 19:06:47 +0000 (16:06 -0300)
commit7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa
tree4b1b8645e4c70ef97f96c08347681f778c3a2c7f
parent4d6101f5fd5d996060eb59f7a01d3d1f842407c1
tools lib traceevent: Fix buffer overflow in arg_eval

Fix buffer overflow observed when running perf test.

The overflow is when trying to evaluate "1ULL << (64 - 1)" which is
resulting in -9223372036854775808 which overflows the 20 character
buffer.

If is possible this bug has been reported before but I still don't see
any fix checked in:

See: https://www.spinics.net/lists/linux-perf-users/msg07714.html

Reported-by: Michael Sartain <mikesart@fastmail.com>
Reported-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Tony Jones <tonyj@suse.de>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a")
Link: http://lkml.kernel.org/r/20190228015532.8941-1-tonyj@suse.de
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/event-parse.c