projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d762f43) | patch
HID: hiddev: fix potential use-after-free
authorJiri Kosina <jkosina@suse.cz>
Tue, 24 May 2011 09:43:18 +0000 (11:43 +0200)
committerJiri Kosina <jkosina@suse.cz>
Tue, 24 May 2011 09:43:18 +0000 (11:43 +0200)
commit7f77897ef2b6a5ee4eb8bc24fe8b1f3eab254328
tree024098e2025c2fbbd3b0a2edf70711ffef76f9b8tree | snapshot
parentd762f4383100c2a87b1a3f2d678cd3b5425655b4commit | diff
HID: hiddev: fix potential use-after-free

Commit 6cb4b040795 ("HID: hiddev: fix race between hiddev_disconnect
and hiddev_release") made it possible to access hiddev (for unlocking
the existance mutex) once hiddev has been kfreed.

Change the order so that this can not happen (always unlock the mutex first,
it is needed only to protect access to ->exist and ->open).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hiddev.c diff | blob | history
John Crispins staging tree