ptp: drop redundant kasprintf() to create worker name
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 26 Oct 2018 21:22:59 +0000 (23:22 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Oct 2018 02:20:06 +0000 (19:20 -0700)
commit822c5f7341366bef761e5e49f05bb8b1b0afccee
tree89d222508b83b263a0d481bcc715124882af1b31
parent0fe5119e267f3e3d8ac206895f5922195ec55a8a
ptp: drop redundant kasprintf() to create worker name

Building with -Wformat-nonliteral, gcc complains

drivers/ptp/ptp_clock.c: In function â€˜ptp_clock_register’:
drivers/ptp/ptp_clock.c:239:26: warning: format not a string literal and no format arguments [-Wformat-nonliteral]
            worker_name : info->name);

kthread_create_worker takes fmt+varargs to set the name of the
worker, and that happens with a vsnprintf() to a stack buffer (that is
then copied into task_comm). So there's no reason not to just pass
"ptp%d", ptp->index to kthread_create_worker() and avoid the
intermediate worker_name variable.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ptp/ptp_clock.c