media: staging: atomisp: remove an useless check
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Mar 2018 19:27:54 +0000 (15:27 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 11:36:28 +0000 (07:36 -0400)
commit83d019bbb0ed214b4ab9d43107cb2fd7be5aeeea
treebd5a6918175fe4e7d7646ca343c7667189f69752
parentdc9f65cf9aea13167bb930d118dbd31ef6f03180
media: staging: atomisp: remove an useless check

There's a check at ia_css_vf_configure() to verify if
binary is not null. However, this is called too late:
drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c:133 ia_css_vf_configure() warn: variable dereferenced before check 'binary' (see line 129)

This test is wrong, as this fuction is only called by
ia_css_binary_fill_info(), in a place that already assumes that
binary is not null, and checks with:
assert(binary != NULL);

So, remove the useless broken extra check.

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c