net: phylink: Fix flow control for fixed-link
authorRené van Dorst <opensource@vdorst.com>
Sat, 27 Jul 2019 09:40:11 +0000 (11:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 27 Jul 2019 21:27:51 +0000 (14:27 -0700)
commit8aace4f3eba2a3ceb431e18683ea0e1ecbade5cd
treecbb8b7bc3418e3b8e7d708bdeb4b9d17f0f6dca7
parent3db1fa8bb489370b6df634a3d548728294139d66
net: phylink: Fix flow control for fixed-link

In phylink_parse_fixedlink() the pl->link_config.advertising bits are AND
with pl->supported, pl->supported is zeroed and only the speed/duplex
modes and MII bits are set.
So pl->link_config.advertising always loses the flow control/pause bits.

By setting Pause and Asym_Pause bits in pl->supported, the flow control
work again when devicetree "pause" is set in fixes-link node and the MAC
advertise that is supports pause.

Results with this patch.

Legend:
- DT = 'Pause' is set in the fixed-link in devicetree.
- validate() = ‘Yes’ means phylink_set(mask, Pause) is set in the
  validate().
- flow = results reported my link is Up line.

+-----+------------+-------+
| DT  | validate() | flow  |
+-----+------------+-------+
| Yes | Yes        | rx/tx |
| No  | Yes        | off   |
| Yes | No         | off   |
+-----+------------+-------+

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: René van Dorst <opensource@vdorst.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c