mtip32xx: fix up the checking for internal command failure
authorJens Axboe <axboe@kernel.dk>
Fri, 23 Jun 2017 15:18:54 +0000 (09:18 -0600)
committerJens Axboe <axboe@kernel.dk>
Fri, 23 Jun 2017 15:18:54 +0000 (09:18 -0600)
commit8c66ac6a28a460273e1ad263bb05056dc0e68760
tree0778d025344fed439505041f203c94a0813be86b
parentf95a0d6a95b12a79b7492da7ab687ae4cd741124
mtip32xx: fix up the checking for internal command failure

This fixes up two commits that have touched this driver. The
command status field is now a blk_status_t, so we can't check
for < 0 and we definitely can't assume it's holding -Exxxx error
values. All we care about here is whether ->status is zero or not.
Check for that, and remove the various attempts at smart error
reporting. Just log to dmesg what command failed, and the
blk_status_t value.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 2a842acab109 ("block: introduce new block status code type")
Fixes: 3f5e6a35774c ("mtip32xx: convert internal command issue to block IO path")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/mtip32xx/mtip32xx.c