509: fix printing uninitialized stack memory when OID is empty
authorEric Biggers <ebiggers3@gmail.com>
Fri, 8 Dec 2017 15:13:28 +0000 (15:13 +0000)
committerDavid Howells <dhowells@redhat.com>
Fri, 8 Dec 2017 15:13:28 +0000 (15:13 +0000)
commit8dfd2f22d3bf3ab7714f7495ad5d897b8845e8c1
treec937db5e51b0f6404d53cb4044e83b8071a8cc51
parent47e0a208fb9d91e3f3c86309e752b13a36470ae8
509: fix printing uninitialized stack memory when OID is empty

Callers of sprint_oid() do not check its return value before printing
the result.  In the case where the OID is zero-length, -EBADMSG was
being returned without anything being written to the buffer, resulting
in uninitialized stack memory being printed.  Fix this by writing
"(bad)" to the buffer in the cases where -EBADMSG is returned.

Fixes: 4f73175d0375 ("X.509: Add utility functions to render OIDs as strings")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
lib/oid_registry.c