projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: de2ee48) | patch
vme: Fix a possible sleep-in-atomic bug in vme_tsi148
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 12 Dec 2017 12:51:53 +0000 (20:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Dec 2017 14:59:18 +0000 (15:59 +0100)
commit97784615ed32c1ef33047e95d4240141258e2cf0
treeadd904df57c13e4223eefad1bd601c3a50706471tree | snapshot
parentde2ee48c39b6af95121b33c6c5531e0475e12a3acommit | diff
vme: Fix a possible sleep-in-atomic bug in vme_tsi148

The driver may sleep under a spinlock.
The function call path is:
tsi148_master_write \ tsi148_master_read (acquire the spinlock)
  vme_register_error_handler
    kmalloc(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vme/vme.c diff | blob | history
John Crispins staging tree