dmaengine: at_hdmac: fix memory leak in at_dma_xlate()
authorRichard Genoud <richard.genoud@gmail.com>
Tue, 27 Nov 2018 16:06:34 +0000 (17:06 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 29 Nov 2018 14:19:41 +0000 (19:49 +0530)
commit98f5f932254b88ce828bc8e4d1642d14e5854caa
treea2eea3540da857c8403d299f263d732ed89543b3
parent651022382c7f8da46cb4872a545ee1da6d097d2a
dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

The leak was found when opening/closing a serial port a great number of
time, increasing kmalloc-32 in slabinfo.

Each time the port was opened, dma_request_slave_channel() was called.
Then, in at_dma_xlate(), atslave was allocated with devm_kzalloc() and
never freed. (Well, it was free at module unload, but that's not what we
want).
So, here, kzalloc is more suited for the job since it has to be freed in
atc_free_chan_resources().

Cc: stable@vger.kernel.org
Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Reported-by: Mario Forner <m.forner@be4energy.com>
Suggested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_hdmac.c