bpf: fix compiler warning with CONFIG_MODULES=n
authorYonghong Song <yhs@fb.com>
Wed, 26 Jun 2019 00:35:03 +0000 (17:35 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 26 Jun 2019 12:44:07 +0000 (14:44 +0200)
commit9db1ff0a415c7de8eb67df5b2c56ac409ccefc37
tree57c28eb0281ef0cf406d7f0a3c41db4969499c0e
parent6bcc617f842cdb5f3d66b3a3f06614a62fab992b
bpf: fix compiler warning with CONFIG_MODULES=n

With CONFIG_MODULES=n, the following compiler warning occurs:
  /data/users/yhs/work/net-next/kernel/trace/bpf_trace.c:605:13: warning:
      ‘do_bpf_send_signal’ defined but not used [-Wunused-function]
  static void do_bpf_send_signal(struct irq_work *entry)

The __init function send_signal_irq_work_init(), which calls
do_bpf_send_signal(), is defined under CONFIG_MODULES. Hence,
when CONFIG_MODULES=n, nobody calls static function do_bpf_send_signal(),
hence the warning.

The init function send_signal_irq_work_init() should work without
CONFIG_MODULES. Moving it out of CONFIG_MODULES
code section fixed the compiler warning, and also make bpf_send_signal()
helper work without CONFIG_MODULES.

Fixes: 8b401f9ed244 ("bpf: implement bpf_send_signal() helper")
Reported-By: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Yonghong Song <yhs@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/trace/bpf_trace.c