ath10k: fix use-after-free in ath10k_wmi_cmd_send_nowait
authorCarl Huang <cjhuang@codeaurora.org>
Mon, 5 Mar 2018 06:44:02 +0000 (14:44 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 26 Mar 2018 15:13:03 +0000 (18:13 +0300)
commit9ef0f58ed7b4a55da4a64641d538e0d9e46579ac
treec2591ea97d34c1a197ff2826c1a9df0e4d25c0e9
parent6b8a127bf66d395705153fdaf3fc0b52bedd2e9f
ath10k: fix use-after-free in ath10k_wmi_cmd_send_nowait

The skb may be freed in tx completion context before
trace_ath10k_wmi_cmd is called. This can be easily captured when
KASAN(Kernel Address Sanitizer) is enabled. The fix is to move
trace_ath10k_wmi_cmd before the send operation. As the ret has no
meaning in trace_ath10k_wmi_cmd then, so remove this parameter too.

Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/trace.h
drivers/net/wireless/ath/ath10k/wmi.c