drm/i915: Perform an invalidate prior to executing golden renderstate
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 8 Aug 2017 13:19:04 +0000 (14:19 +0100)
committerJani Nikula <jani.nikula@intel.com>
Mon, 14 Aug 2017 16:28:06 +0000 (19:28 +0300)
commita0125a932e917cb507b682cb66645efdca1f8cab
tree765cd308f5775ac6c6b11f2d77253d77c34e89a7
parent26a72e8a8d0707f1d49133a19c027a3af9fcfdcb
drm/i915: Perform an invalidate prior to executing golden renderstate

As we may have just bound the renderstate into the GGTT for execution, we
need to ensure that the GTT TLB are also flushed.

On snb-gt2, this would cause a random GPU hang at the start of a new
context (e.g. boot) and on snb-gt1, it was causing the renderstate batch
to take ~10s. It was the GPU hang that revealed the truth, as the CS
gleefully executed beyond the end of the golden renderstate batch, a good
indicator for a GTT TLB miss.

Fixes: 20fe17aa52dc ("drm/i915: Remove redundant TLB invalidate on switching contexts")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://patchwork.freedesktop.org/patch/msgid/20170808131904.1385-1-chris@chris-wilson.co.uk
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: <drm-intel-fixes@lists.freedesktop.org> # v4.12-rc1+
(cherry picked from commit 802673d66f8a6ded5d2689d597853c7bb3a70163)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_gem_render_state.c