projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cc25eaa) | patch
wan/x25_asy: integer overflow in x25_asy_change_mtu()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 17 Jul 2014 10:50:45 +0000 (13:50 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jul 2014 23:47:50 +0000 (16:47 -0700)
commita28d0e873d2899bd750ae495f84fe9c1a2f53809
treec298871f2dfa4dc8f93e0f2928aa844b1cda20f1tree | snapshot
parentcc25eaae238ddd693aa5eaa73e565d8ff4915f6ecommit | diff
wan/x25_asy: integer overflow in x25_asy_change_mtu()

If "newmtu * 2 + 4" is too large then it can cause an integer overflow
leading to memory corruption.  Eric Dumazet suggests that 65534 is a
reasonable upper limit.

Btw, "newmtu" is not allowed to be a negative number because of the
check in dev_set_mtu(), so that's ok.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/x25_asy.c diff | blob | history
John Crispins staging tree