HID: sony: Fix input device leak when connecting a DS4 twice using USB/BT
authorRoderick Colenbrander <roderick.colenbrander@sony.com>
Sat, 25 Feb 2017 00:14:15 +0000 (16:14 -0800)
committerJiri Kosina <jkosina@suse.cz>
Mon, 6 Mar 2017 13:43:16 +0000 (14:43 +0100)
commita687c5765b5ae19fe559e14615ddc87ebb46d409
tree437a1d7ac9f5981b20f9869349f9a455873040cc
parentf2f10b7e722a75c6d75a7f7cd06b0eee3ae20f7c
HID: sony: Fix input device leak when connecting a DS4 twice using USB/BT

When a user connects a DS4 twice using USB and BT, we reject the
second device connection after the setup work. We then perform
a cleanup, but during cleanup we are not removing the touchpad
device. This leads to leakage of an input device, which we would
never remove. It can likely result into a kernel oops as well
when the touchpad evdev node is accessed and the underlaying HID
device has been removed from the system.

[jkosina@suse.cz: added stable annotation]
Fixes: ac797b95f532 ("HID: sony: Make the DS4 touchpad a separate device")
Cc: stable@vger.kernel.org
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-sony.c