qlogicpti: Return correct error code
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Wed, 17 Feb 2016 13:32:54 +0000 (19:02 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 2 Mar 2016 01:06:49 +0000 (20:06 -0500)
commita6d24143fca421c836f78538705c8e5b3ef04e3d
treedcfed74a1ac7ec1cefd9210c9e541b1f16d3c01c
parent8d5dbec3bcb24a7d071962448e0fecaca8c75cc7
qlogicpti: Return correct error code

The return value of of_ioremap on failure should be -ENODEV and not
-1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//<smpl>
@@
expression *e;
@@

e = of_ioremap(...);
if (e == NULL) {
...
return
- -1
+ -ENODEV
;
}
//</smpl>

The single call site only checks that the return value is less than 0,
hence no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Reviewed-by: Hannes Reinicke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qlogicpti.c