ARM/arm64: KVM: fix use of WnR bit in kvm_is_write_fault()
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 9 Sep 2014 10:27:09 +0000 (11:27 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Thu, 11 Sep 2014 10:31:13 +0000 (11:31 +0100)
commita7d079cea2dffb112e26da2566dd84c0ef1fce97
tree934d671f75dd5aa1f30b0f9a5fdd18392a1b6528
parentde56fb1923ca11f428bf557870e0faa99f38762e
ARM/arm64: KVM: fix use of WnR bit in kvm_is_write_fault()

The ISS encoding for an exception from a Data Abort has a WnR
bit[6] that indicates whether the Data Abort was caused by a
read or a write instruction. While there are several fields
in the encoding that are only valid if the ISV bit[24] is set,
WnR is not one of them, so we can read it unconditionally.

Instead of fixing both implementations of kvm_is_write_fault()
in place, reimplement it just once using kvm_vcpu_dabt_iswrite(),
which already does the right thing with respect to the WnR bit.
Also fix up the callers to pass 'vcpu'

Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
arch/arm/include/asm/kvm_mmu.h
arch/arm/kvm/mmu.c
arch/arm64/include/asm/kvm_mmu.h